creations/profilePage
1
2
Fork 4
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix two simple bugs with reviews and timezone showing even if they dont exist
All checks were successful
Code quality checks / biome (push) Successful in 9s
Details

Browse source
This commit is contained in:
creations 2025-05-31 10:56:44 -04:00
parent 152d1c475f
commit 9ca877602f
Signed by: creations
GPG key ID: 8F553AA4320FC711
2 changed files with 9 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

11
public/js/index.js
View file

@ -132,7 +132,7 @@ function resolveActivityImage(img, applicationId) {
async function populateReviews(userId) { async function populateReviews(userId) {
if (!reviewURL || !userId || isLoadingReviews || !hasMoreReviews) return; if (!reviewURL || !userId || isLoadingReviews || !hasMoreReviews) return;
const reviewSection = document.querySelector(".reviews"); const reviewSection = document.getElementById("reviews-section");
const reviewList = reviewSection?.querySelector(".reviews-list"); const reviewList = reviewSection?.querySelector(".reviews-list");
if (!reviewList) return; if (!reviewList) return;
@ -201,7 +201,9 @@ async function populateReviews(userId) {
if (currentReviewOffset === 0) reviewList.innerHTML = reviewsHTML; if (currentReviewOffset === 0) reviewList.innerHTML = reviewsHTML;
else reviewList.insertAdjacentHTML("beforeend", reviewsHTML); else reviewList.insertAdjacentHTML("beforeend", reviewsHTML);
reviewSection.classList.remove("hidden"); if (data.reviews.length > 0 && reviewsHTML) {
reviewSection.classList.remove("hidden");
}
hasMoreReviews = data.hasNextPage; hasMoreReviews = data.hasNextPage;
isLoadingReviews = false; isLoadingReviews = false;
@ -238,7 +240,8 @@ function populateTimezone(userId, format = "24h") {
timezoneLoaded = true; timezoneLoaded = true;
const timezoneEl = document.querySelector(".timezone-value"); const timezoneEl = document.querySelector(".timezone-value");
if (!timezoneEl) return; const timezoneWrapper = document.getElementById("timezone-wrapper");
if (!timezoneEl || !timezoneWrapper) return;
const now = new Date(); const now = new Date();
@ -261,7 +264,7 @@ function populateTimezone(userId, format = "24h") {
timezoneEl.textContent = format === "24h" ? time24 : time12; timezoneEl.textContent = format === "24h" ? time24 : time12;
timezoneEl.title = `${format === "12h" ? time24 : time12} (${currentTimezone})`; timezoneEl.title = `${format === "12h" ? time24 : time12} (${currentTimezone})`;
timezoneEl.classList.remove("hidden"); timezoneWrapper.classList.remove("hidden");
} }
fetchTimezone(); fetchTimezone();

4
src/views/index.html
View file

@ -27,7 +27,7 @@
style="opacity: 0.5" loading="lazy" /> style="opacity: 0.5" loading="lazy" />
</a> </a>
<div class="timezone-wrapper" id="timezone-wrapper" aria-label="Timezone Information"> <div class="timezone-wrapper hidden" id="timezone-wrapper" aria-label="Timezone Information">
<span class="timezone-label">Users Time:</span> <span class="timezone-label">Users Time:</span>
<span class="timezone-value"></span> <span class="timezone-value"></span>
</div> </div>
@ -61,7 +61,7 @@
</section> </section>
</main> </main>
<section class="reviews hidden" aria-label="User Reviews"> <section class="reviews hidden" aria-label="User Reviews" id="reviews-section">
<h2>User Reviews</h2> <h2>User Reviews</h2>
<ul class="reviews-list"> <ul class="reviews-list">
</ul> </ul>